Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a MSRV policy #229

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add a MSRV policy #229

merged 1 commit into from
Jul 31, 2024

Conversation

daxpedda
Copy link
Member

This MSRV policy is copied from Winit.
Orbital is excluded from it because it requires nightly to begin with.

As discussed in #228 (comment).

@daxpedda daxpedda added the documentation Improvements or additions to documentation label Jul 23, 2024
@daxpedda daxpedda requested a review from john01dav as a code owner July 23, 2024 09:21
@daxpedda
Add a MSRV policy
1df4388 
And exclude Orbital from it as it requires nightly anyway.
notgull
notgull approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

While I dislike having weird exceptions in the MSRV for certain platforms, I see the fact that it is necessary.

@daxpedda daxpedda merged commit a9f82e6 into rust-windowing:master Jul 31, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

@john01dav john01dav Awaiting requested review from john01dav

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxpedda @notgull